fix(cli): list-source-runs added null checking #12369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkarchacryl
commented
Jan 16, 2025
| @@ -115,17 +115,17 @@ datahub ingest -c ./examples/recipes/example_to_datahub_rest.dhub.yaml --dry-run | |||
| datahub ingest -c ./examples/recipes/example_to_datahub_rest.dhub.yaml -n | |||
| ``` | |||
|
|
|||
| #### ingest --list-source-runs | |||
There was a problem hiding this comment.
It was always "datahub ingest list-source-runs" so just correcting the doc here
github-actions
bot
added
ingestion
asikowitz
approved these changes
Jan 16, 2025
Codecov ReportAttention: Patch coverage is
... and 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
kevinkarchacryl
merged commit bfe9758
into
datahub-project:master
187 of 218 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was seeing some errors when running against the messed up state of Paxos's ingestion. I added a bunch of null checks and tested with: missing sources, missing urns, correct sources, correct urns. Sample result for Paxos:
